Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Basic Api Key connection #311

Merged
merged 19 commits into from
Sep 15, 2022
Merged

Create Basic Api Key connection #311

merged 19 commits into from
Sep 15, 2022

Conversation

mohyour
Copy link
Contributor

@mohyour mohyour commented Sep 13, 2022

No description provided.

@mohyour mohyour changed the title [DRAFT] Create Basic Api Key connection Create Basic Api Key connection Sep 14, 2022
QuintinWillison
QuintinWillison suggested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave others who have more Python knowledge than me to comment on API as well as implementation details, in respect of idiomatic observations, however I have a few general observations...

ably/__init__.py Show resolved Hide resolved
test/ably/restsetup.py Show resolved Hide resolved
ably/realtime/connection.py Outdated Show resolved Hide resolved
ably/realtime/realtime.py Outdated Show resolved Hide resolved
owenpearson
owenpearson approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

QuintinWillison
QuintinWillison approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@owenpearson owenpearson merged commit ee04a82 into integration/realtime Sep 15, 2022
@owenpearson owenpearson deleted the api-key-connection branch September 15, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@owenpearson owenpearson owenpearson approved these changes

@lmars lmars Awaiting requested review from lmars

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohyour @QuintinWillison @owenpearson